feat(tracing): Promote enableLongTask to option of BrowserTracing
#6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jan 18, 2023
| @@ -124,7 +134,8 @@ const DEFAULT_BROWSER_TRACING_OPTIONS: BrowserTracingOptions = { | |||
| routingInstrumentation: instrumentRoutingWithDefaults, | |||
| startTransactionOnLocationChange: true, | |||
| startTransactionOnPageLoad: true, | |||
| _experiments: { enableLongTask: true, enableInteractions: false }, | |||
| enableLongTask: true, | |||
| _experiments: {}, | |||
There was a problem hiding this comment.
m: Did we want to remove enableInteractions?
There was a problem hiding this comment.
That is false by default, so should be the same as not having it at all, I figured?
There was a problem hiding this comment.
yeah good point, save some bytes!
size-limit report 📦
|
AbhiPrasad
approved these changes
Jan 18, 2023
Good point! I created a PR that we can merge once this is released: getsentry/sentry-docs#6104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This experiment was on by default, which showed that this is not actually an experiment anymore, and thus should be promoted to a regular option.