ref(nextjs): Remove NFT build time exclusions

[lforst]

First, a bit of history: A while back we decided to exclude our build time dependencies from the files that are uploaded to AWS Lambdas through Vercel. This was done by modifying the NFT Plugin Next.js injects. This caused us to break during runtime because the build files could be required when the server starts. The fix for that however broke next dev and we had to convert our withSentryConfig function to return a function so that we can make an exception for the dev phase.

The last change caused an avalanche of issues to appear which we mostly brushed off and told users to "fix" their Next.js configs to be able to deal with withSentryConfig to return a function.
The issues have now reached a critical mass so we should unship this feature, just so we don't ruin DX for a ton of people.

Here are the issues related to this I could find retroactively:

• Sentry for Nextjs messes up the build process #6472
• [nextjs] v7.29.0 breaks reading next.config.js resulting into missing runtimeConfig #6691
• withSentryConfig breaks Nextjs image optimization with some urls in production starting with @sentry/nextjs 7.22.0 #6401
• [NEXT] withSentryConfig is throwing error with custom webpack for version 7.13 during build  #6355
• [Next] My webpack config is ignored since 7.22 #6339
• @sentry/next.js v 7.23.1 stops sending events #6475
• Next.js Config as function is unsupported sometime after 7.12.1 #6447
• Next.js SDK incompatibility with bundle analyzer #6336
• Next images config is not working with sentry version 7.22.0 #6363

IMO the build time dependencies we have aren't that huge that it is worth adding a lot of complexity and DX degradation and I verified that Sentry CLI is still not included in the generated nft files.

[github-actions]

size-limit report 📦

Path	Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified)	19.82 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)	61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)	18.5 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)	54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified)	20.22 KB (0%)
@sentry/browser - Webpack (minified)	66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified)	20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)	47.52 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)	26.74 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)	25.03 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)	43.12 KB (-0.82% 🔽)
@sentry/replay - Webpack (gzipped + minified)	38.45 KB (-1% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)	60.37 KB (-0.58% 🔽)

[AbhiPrasad]

🚀

[baraeb92]

Maybe doing this on next major version can be done, as long as Sentry team gives a clear warning and how to fix on the release note or documentation.

@lforst @AbhiPrasad

[lforst]

@baraeb92 First, let's see if the community even sees a need for removing build-time deps from NFT dependencies. Even though doing it in a major would make the most sense, from what I've seen, if we return a function, many people have trouble setting up Sentry when their configs are more complex.