Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Add option to capture local variables for caught exceptions via LocalVariables integration #6876

Merged
merged 5 commits into from Jan 23, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 19, 2023

Currently the LocalVariables integration only captures local variables for uncaught exceptions. This PR adds an option (disabled by default) that allows capturing variables for caught exceptions too.

This was discussed as a a potential addition to the LocalVariables integration and since I need to update the docs for #6874, I may as well include this change too.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sounds reasonable enough for me, we also then have to document it.

packages/node/src/integrations/localvariables.ts Outdated Show resolved Hide resolved
@timfish timfish self-assigned this Jan 21, 2023
@AbhiPrasad AbhiPrasad merged commit 6bca76e into getsentry:master Jan 23, 2023
@timfish timfish deleted the feat/local-variables-for-caught branch February 8, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants