Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Remix Causes Remix defer to fail in @remix-run/node@1.11.0 #6883

Closed
3 tasks done
rubber-duck-software opened this issue Jan 19, 2023 · 6 comments · Fixed by #8305
Closed
3 tasks done

Sentry Remix Causes Remix defer to fail in @remix-run/node@1.11.0 #6883

rubber-duck-software opened this issue Jan 19, 2023 · 6 comments · Fixed by #8305

Comments

@rubber-duck-software
Copy link

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/angular

SDK Version

7.31.1

Framework Version

Remix 1.11.0

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

Use deferred data loading in Remix@1.11.0. The output shape when calling useLoaderData will be changed. (The data is under the "data" key instead of being the return value)

Expected Result

useLoaderData should return what was passed to defer

Actual Result

useLoaderData returns what was passed to defer wrapped in an object.

@lforst
Copy link
Member

lforst commented Jan 20, 2023

Hi, since the 1.11.0 Remix release is quite new we have to check for compatibility so stay tuned! We're tracking it here: #6888

@rubber-duck-software
Copy link
Author

Thanks for the quick response. Glad you guys are tracking this. Quick note on the nature of the issue: Here Sentry.init actually changes the behavior of Remix in a breaking way (I presume there is monkey patching or something involved). The issue is not that Remix 1.11.0 breaks Sentry, but rather Sentry breaks Remix 1.11.0.

@dmarkow
Copy link

dmarkow commented Jan 26, 2023

This might be the same issue that I opened on Remix earlier this week (remix-run/remix#5211). If so, it's not related to Sentry (my reproduction was not using Sentry at all).

@HazAT
Copy link
Member

HazAT commented Feb 13, 2023

Related: #6888

@dwene
Copy link

dwene commented May 12, 2023

I believe I am also running into this issue.

Remix 1.15.0
Latest @sentry/remix

@dwene
Copy link

dwene commented May 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants