Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop replay recording when hitting a rate limit #6984

Closed
Lms24 opened this issue Jan 31, 2023 · 0 comments · Fixed by #7018
Closed

Stop replay recording when hitting a rate limit #6984

Lms24 opened this issue Jan 31, 2023 · 0 comments · Fixed by #7018

Comments

@Lms24
Copy link
Member

Lms24 commented Jan 31, 2023

Problem Statement

Right now, we're pausing recording when we hit a rate limit while replay is active. As discussed last week in person, we figured it'd be preferable to entirely stop the recording in this case instead, to avoid future rate limiting once all currently paused clients restart recording.

Solution Brainstorm

We're already stopping recording when receiving erroneous responses from Sentry so it's probably enough to delete some code and apply the same logic for rate limit responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant