fix(nextjs): Inject client config into _app instead of main
#7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Feb 1, 2023
longzheng
reviewed
Feb 1, 2023
| entryPointName === 'main-app' // entrypoint for `/app` pages | ||
| // entrypoint for `/pages` pages - this is included on all clientside pages | ||
| // It's important that we inject the SDK into this file and not into 'main' because in 'main' | ||
| // some important Next.js code (like the setup code for getCongig()) is located and some users |
There was a problem hiding this comment.
I think this is a typo. getCongig() should be getConfig()
There was a problem hiding this comment.
Thanks for letting us know! :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7006
Apparently with #6927 we broke some ordering of SDK injection for stuff like Next.js'
getConfig()to work.