You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While debugging a failing replay integration test in #7011, we just realized that the global installedIntegrations causes problems for the replay integration CDN bundle.
This is problematic, because the replay integration CDN bundle will get its own copy of installedIntegrations, which will always be empty as it is not populated by the SDK:
// Both bundles maintain separate copies of `installedIntegrations` and only the SDK's field will be used
SDk bundle
sentry.init()
sentry.addinitegration()
installedIntegrations = [ 'Replay', 'Dedupe', ....]
replay bundle
installedIntegrations = []
prepareEvent() // prepareEvent accesses installedIntegrations but takes the replay bundle's version, which will always be empty
Solution Brainstorm
We should get rid of this global as this is very problematic, albeit in this particular case, only for the replay integration.
It should be good enough to use the _integrations field in BaseClient to avoid a breaking change for now and once we move to v8, we can add public getter/a cleaner way to access this field.
The text was updated successfully, but these errors were encountered:
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
Problem Statement
While debugging a failing replay integration test in #7011, we just realized that the global
installedIntegrations
causes problems for the replay integration CDN bundle.This is problematic, because the replay integration CDN bundle will get its own copy of
installedIntegrations
, which will always be empty as it is not populated by the SDK:Solution Brainstorm
We should get rid of this global as this is very problematic, albeit in this particular case, only for the replay integration.
It should be good enough to use the
_integrations
field inBaseClient
to avoid a breaking change for now and once we move to v8, we can add public getter/a cleaner way to access this field.The text was updated successfully, but these errors were encountered: