Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global installedIntegrations variable #7028

Closed
Lms24 opened this issue Feb 1, 2023 · 2 comments
Closed

Remove global installedIntegrations variable #7028

Lms24 opened this issue Feb 1, 2023 · 2 comments

Comments

@Lms24
Copy link
Member

Lms24 commented Feb 1, 2023

Problem Statement

While debugging a failing replay integration test in #7011, we just realized that the global installedIntegrations causes problems for the replay integration CDN bundle.

This is problematic, because the replay integration CDN bundle will get its own copy of installedIntegrations, which will always be empty as it is not populated by the SDK:

// Both bundles maintain separate copies of `installedIntegrations` and only the SDK's field will be used
SDk bundle
	sentry.init()
	sentry.addinitegration()
	installedIntegrations = [ 'Replay', 'Dedupe', ....]

replay bundle
	installedIntegrations = []
	prepareEvent() // prepareEvent accesses installedIntegrations but takes the replay bundle's version, which will always be empty

Solution Brainstorm

We should get rid of this global as this is very problematic, albeit in this particular case, only for the replay integration.
It should be good enough to use the _integrations field in BaseClient to avoid a breaking change for now and once we move to v8, we can add public getter/a cleaner way to access this field.

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@mydea
Copy link
Member

mydea commented Oct 24, 2023

I'm closing this as we're going to generally change this in v8, I don't think we'll keep this after that!

@mydea mydea closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants