fix(replay): Don't mangle private _cssText
rrweb property
#7033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our mangler strikes again! This time in
rrweb
whereattributes._cssText
is accessed (example). This PR adds this property to the list of reserved properties excluded from mangling.Note: I went through the rrweb source code and didn't find other private properties, leading me to believe that for now we should be good in terms of bundling. rrweb accesses a bunch of double
__
variables (e.g.__sn
here) but these are not touched by terser and hence fine (+ I double checked that they actually end up in our bundles).h/t @billyvg for raising this issue