Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): LocalVariables, Improve frame matching for ESM #7049

Merged
merged 9 commits into from Feb 6, 2023
Merged

fix(node): LocalVariables, Improve frame matching for ESM #7049

merged 9 commits into from Feb 6, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 3, 2023

In #7046 there were issues reported with LocalVariables and ESM.

The call frame context appears to be lost from the debugger in the above reported case but I did find that frame matching could be improved.

This PR:

  • Adds a LocalVariables test with ESM
  • Ensures that we don't use obj.className if it's undefined

@timfish timfish mentioned this pull request Feb 3, 2023
Closed
3 tasks
@AbhiPrasad
Copy link
Member

Maybe we just disable the Node 10 tests? The likelihood of Node 10 + mjs seems pretty small, we can even add a note to the docs that it's not supported.

@AbhiPrasad AbhiPrasad merged commit 17db8e2 into getsentry:develop Feb 6, 2023
@timfish timfish deleted the fix/local-variables-esm branch February 6, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timfish @AbhiPrasad