Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Send client_report when replay sending fails #7093

Merged
merged 3 commits into from Feb 9, 2023
Merged

feat(replay): Send client_report when replay sending fails #7093

merged 3 commits into from Feb 9, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 8, 2023

This leverages the new client_report categories.

See getsentry/develop#830

Closes #6774

@mydea mydea requested review from billyvg and Lms24 February 8, 2023 14:32
@mydea mydea self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.06 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 62.19 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.33 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.42 KB (0%)
@sentry/browser - Webpack (minified) 66.77 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.45 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.74 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.97 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.23 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.92 KB (+0.1% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.84 KB (+0.13% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.63 KB (+0.06% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.16 KB (+0.08% 🔺)

Lms24
Lms24 approved these changes Feb 8, 2023
View reviewed changes
packages/replay/src/replay.ts Outdated Show resolved Hide resolved
packages/replay/src/util/addEvent.ts Outdated Show resolved Hide resolved
mydea and others added 2 commits February 9, 2023 10:19
@mydea
feat(replay): Send client_report when replay sending fails
56937f6 
This leverages the new client_report categories.
@mydea @Lms24
Apply suggestions from code review
1a08cd9 
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@mydea mydea merged commit 58bb657 into develop Feb 9, 2023
@mydea mydea deleted the fn/replay-client-report branch February 9, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Package: replay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new client_report category for replay
3 participants
@mydea @billyvg @Lms24