Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Improve ignoring of rrweb-internal errors #7094

Merged
merged 2 commits into from Feb 9, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 8, 2023

This updates rrweb to https://github.com/getsentry/rrweb/releases/tag/1.101.0, which mainly improves our wrapping of rrweb errors.

@mydea mydea requested review from billyvg and Lms24 February 8, 2023 14:39
@mydea mydea self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.06 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 62.19 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 55.33 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.42 KB (0%)
@sentry/browser - Webpack (minified) 66.77 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.45 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.74 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.97 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.23 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.23 KB (-3.76% 🔽)
@sentry/replay - Webpack (gzipped + minified) 36.65 KB (-5.53% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 59.9 KB (-2.77% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.44 KB (-3.06% 🔽)

@Lms24
Copy link
Member

Lms24 commented Feb 8, 2023

How does this reduce bundle size so much 🤔

@mydea
Copy link
Member Author

mydea commented Feb 9, 2023

How does this reduce bundle size so much 🤔

Yeah, I also wondered about this 😅

This updates rrweb to https://github.com/getsentry/rrweb/releases/tag/1.101.0, which mainly improves our wrapping of rrweb errors.
@mydea mydea merged commit 9fb6d0d into develop Feb 9, 2023
@mydea mydea deleted the fn/update-rrweb branch February 9, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants