Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Put abs_path into stack frame object #7167

Merged
merged 3 commits into from Feb 14, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 13, 2023

Ref: #7161 (comment)

In order to have a mapping from filename to debug_id for #7161 (comment) we need to have a record of a file name that is generally considered immutable: abs_path.

This PR puts the abs_path property onto stack frames when generating them. Usually, it is just equivalent to filename.

We consider this change safe since Relay just copies filename over to abs_path if it is missing: https://github.com/getsentry/relay/blob/1e470ec87aee8fb9214844a1cf5eaa5257ea3d69/relay-general/src/store/normalize/stacktrace.rs#L27-L29

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.08 KB (+0.05% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.21 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.71 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.35 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.43 KB (+0.04% 🔺)
@sentry/browser - Webpack (minified) 66.79 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.47 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.86 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (+0.04% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.49 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 36.89 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.18 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.74 KB (+0.02% 🔺)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

Replay SDK metrics 🚀

    Plain +Sentry +Replay
Revision Value Value Diff Ratio Value Diff Ratio
LCP This PR d604022 91.81 ms 125.40 ms +33.59 ms +36.58 % 150.64 ms +58.83 ms +64.08 %
Previous a961e57 73.75 ms 105.00 ms +31.25 ms +42.37 % 128.50 ms +54.75 ms +74.24 %
CLS This PR d604022 0.06 ms 0.06 ms -0.00 ms -0.01 % 0.06 ms -0.00 ms -0.24 %
Previous a961e57 0.06 ms 0.06 ms -0.00 ms -0.67 % 0.06 ms -0.00 ms -0.27 %
CPU This PR d604022 21.88 % 24.23 % +2.35 pp +10.74 % 29.53 % +7.65 pp +34.95 %
Previous a961e57 14.17 % 13.89 % -0.28 pp -2.00 % 20.67 % +6.50 pp +45.87 %
JS heap avg This PR d604022 1.94 MB 1.99 MB +51.06 kB +2.64 % 2.87 MB +930.16 kB +48.06 %
Previous a961e57 1.94 MB 2 MB +56.15 kB +2.89 % 2.87 MB +929.18 kB +47.84 %
JS heap max This PR d604022 2.3 MB 2.57 MB +265.92 kB +11.55 % 3.35 MB +1.05 MB +45.68 %
Previous a961e57 2.3 MB 2.54 MB +240.46 kB +10.44 % 3.37 MB +1.07 MB +46.27 %
netTx This PR d604022 0 B 0 B 0 B n/a 2.21 kB +2.21 kB n/a
Previous a961e57 0 B 0 B 0 B n/a 2.21 kB +2.21 kB n/a
netRx This PR d604022 0 B 0 B 0 B n/a 41 B +41 B n/a
Previous a961e57 0 B 0 B 0 B n/a 41 B +41 B n/a
netCount This PR d604022 0 0 0 n/a 1 +1 n/a
Previous a961e57 0 0 0 n/a 1 +1 n/a
netTime This PR d604022 0.00 ms 0.00 ms 0.00 ms n/a 109.63 ms +109.63 ms n/a
Previous a961e57 0.00 ms 0.00 ms 0.00 ms n/a 92.73 ms +92.73 ms n/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
a961e57+54.75 ms-0.00 ms+6.50 pp+929.18 kB+1.07 MB+2.21 kB+41 B+1+92.73 ms
f7c0a2f+46.14 ms+0.00 ms+6.37 pp+921.47 kB+1.06 MB+2.23 kB+41 B+1+207.30 ms
cb19818+57.16 ms+0.00 ms+11.95 pp+1.07 MB+2.21 MB+2.52 kB+41 B+1+111.50 ms
ee301c3+71.07 ms-0.00 ms+12.64 pp+1.07 MB+2.22 MB+2.55 kB+41 B+1+94.67 ms
93c4759+61.10 ms-0.00 ms+12.72 pp+1.08 MB+2.19 MB+2.57 kB+41 B+1+116.75 ms
274f489+63.60 ms-0.00 ms+11.56 pp+1.08 MB+2.2 MB+2.56 kB+41 B+1+116.60 ms
4827b60+58.67 ms+0.00 ms+18.38 pp+1.07 MB+2.22 MB+2.6 kB+41 B+1+91.21 ms
c3806eb+79.85 ms-0.00 ms+12.10 pp+1.05 MB+2.16 MB+2.54 kB+41 B+1+93.58 ms
b49d9f7+52.79 ms-0.00 ms+15.46 pp+1.07 MB+2.21 MB+2.59 kB+41 B+1+70.48 ms
7e57cb7+47.89 ms+0.00 ms+10.59 pp+1.09 MB+2.21 MB+2.59 kB+41 B+1+72.93 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Tue, 14 Feb 2023 08:34:12 GMT

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would be nice to be able to enforce that it is immutable, but I guess that's OK this way as well.

@lforst lforst merged commit e9eec27 into develop Feb 14, 2023
@lforst lforst deleted the lforst-put-abspath-in-stackframe branch February 14, 2023 08:53
ramchaik pushed a commit to ramchaik/sentry-javascript that referenced this pull request Feb 14, 2023
krystofwoldrich added a commit to getsentry/sentry-react-native that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants