Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Skip empty integrations #7204

Merged
merged 1 commit into from Feb 16, 2023
Merged

fix(core): Skip empty integrations #7204

merged 1 commit into from Feb 16, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 16, 2023

In the case when a user adds an empty integration, we want to handle this more gracefully instead of erroring out.

Closes #7200

In the case when a user adds an empty integration, we want to handle this more gracefully instead of erroring out.
@mydea mydea self-assigned this Feb 16, 2023
@mydea mydea enabled auto-merge (squash) February 16, 2023 14:25
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.05 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.14 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.68 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.29 KB (+0.01% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.41 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified) 66.73 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.44 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.78 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.93 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.2 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.52 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 36.72 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.15 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 53.75 KB (+0.01% 🔺)

@mydea mydea merged commit 5c4af0c into develop Feb 16, 2023
@mydea mydea deleted the fn/check-integrations branch February 16, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK throws Exception if integration is undefined
2 participants