Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam of Errors from framework #7239

Closed
3 tasks done
smeubank opened this issue Feb 21, 2023 · 3 comments
Closed
3 tasks done

Spam of Errors from framework #7239

smeubank opened this issue Feb 21, 2023 · 3 comments
Assignees

Comments

@smeubank
Copy link
Member

smeubank commented Feb 21, 2023

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g. bundle.tracing.min.js) in your SDK setup.

@sentry/next

SDK Version

7.12.1

Framework Version

13?

Link to Sentry event

No response

SDK Setup

customer provided in another channel

Steps to Reproduce

NextJS applicaiton throwing errors, seems a pattern with hydration errors in particular

Expected Result

Do not receive errors in Sentry which occur within the framework

Errors which do appear in Sentry should not be marked as missing source maps related to framework code

Actual Result

Only receive errors in Sentry (costly to quota) which are questionably relevant for the user

Do not flag issue as missing source maps for framework specific code

image

@smeubank
Copy link
Member Author

Regarding hydration error spam:
As discussed in the linked issue it is questionable if we can say all hydration errors are useless. What we can do is in product make proactive suggestions to the user on how to get rid of them (if they want) with beforeSend and/or ignoreError

getsentry/sentry#44877

Regarding framework source code:
Framework source code was incorrectly being marked as in app (part of customer code)

fix with this PR: #7097 in release 7.37

marks the stack frames as inApp:false so they're no longer relevant. Most relevant should become useful then

In case framework code IS useful:
There are situations like below where the user may want to upload min framework code. To do so they need to widen scope, this is not default because it increases upload time/size of source maps

So in product similar to above, we need to detect these tpes of stack trace errors based on some pattern

  1. suggest they widenScope
  2. we can consder marking these as irrelevant frames in SDK inApp:false

image

image

In this example to consider, if marking them all as inApp fale, then the stack trace will be empty but they don't have use for the user. You should still be able to see them, by selecting raw stack trace. However it is unclear the logic behind most relevant being selectable

@smeubank
Copy link
Member Author

Just need to update with the outcome of changes from above PRs, and if shipped, and if we can confirm. Should try to find a way to quantify the impact

@lforst
Copy link
Member

lforst commented Mar 13, 2023

Superseded by #7432

@lforst lforst closed this as completed Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants