fix(serverless): Capture custom tags in error events of GCP functions #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
Lms24
requested review from
a team,
mydea,
AbhiPrasad and
lforst
and removed request for
a team
lforst
approved these changes
Feb 28, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #7222, our GCP function
wrapHttpFunctionhandler didn't capture custom tags in error events. We suspect that this was caused by the SDK listening to errors on the wrong domain. This PR changes the way we listen to errors by directly try/catching the function instead of listening to the domain's error callback.h/t @lforst for debugging this
fixes #7222