feat(vue): Log errors to the console by default #7310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
mydea,
AbhiPrasad and
lforst
and removed request for
a team
lforst
approved these changes
Mar 1, 2023
mydea
approved these changes
Mar 1, 2023
Replay SDK metrics 🚀
develop |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| 3ba8e0b | +11.39 ms | +0.26 ms | +18.59 pp | +7.64 MB | +10.42 MB | +105.73 kB | +332 B | +3 | +67.85 ms |
| dbd7a81 | +98.37 ms | -0.00 ms | +6.68 pp | +1.64 MB | +1.82 MB | +2.23 kB | +41 B | +1 | +124.71 ms |
| dbd7a81 | +86.19 ms | -0.00 ms | +6.77 pp | +1.58 MB | +1.67 MB | +2.23 kB | +41 B | +1 | +87.99 ms |
| 67b0684 | +84.74 ms | -0.00 ms | +7.38 pp | +1.7 MB | +1.81 MB | +2.23 kB | +41 B | +1 | +85.52 ms |
| 4b95c04 | +57.56 ms | -0.00 ms | +7.94 pp | +920.88 kB | +1.05 MB | +2.21 kB | +41 B | +1 | +90.32 ms |
| e60cd02 | +56.25 ms | -0.00 ms | +6.32 pp | +927.44 kB | +1.06 MB | +2.21 kB | +41 B | +1 | +117.55 ms |
| e25c067 | +48.34 ms | +0.00 ms | +5.59 pp | +926.37 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +65.23 ms |
| b1b249b | +43.88 ms | +0.00 ms | +4.80 pp | +937.99 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +111.56 ms |
| 12e34d4 | +28.57 ms | +0.00 ms | +5.77 pp | +930.12 kB | +1.04 MB | +2.26 kB | +41 B | +1 | +109.67 ms |
| c46c56c | +65.45 ms | -0.00 ms | +5.38 pp | +930.26 kB | +1.07 MB | +2.21 kB | +41 B | +1 | +91.29 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 01 Mar 2023 14:57:28 GMT
Last updated: Wed, 01 Mar 2023 14:57:28 GMT
Lms24
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Mar 2, 2023
Following getsentry/sentry-javascript#7310 where we flipped the default value of `logErrors` from `false` to `true`, this PR updates the docs accordingly and removes the now obsolete warning regarding the SDK suppressing error logs by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As brought up by @cleptric, right now our Vue SDK doesn't log errors occurring in the Vue renderer to the console by default. Users need to manually set
logErrors: trueto enable logging of errors.After an internal discussion, we decided to log errors by default. Users can continue to use
logErrorsto opt out of that.ref: #1416
Docs PR: getsentry/sentry-docs#6392