Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ensure we use the same default environment everywhere #7327

Merged
merged 1 commit into from Mar 6, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 3, 2023

This PR adjusts our code to use the same default environment everywhere in the codebase for consistency.
Currently, we use production some places and '' in others.

I may have missed something, but tried to find all places using this.

Closes #6239

@mydea mydea self-assigned this Mar 3, 2023
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just have to be aware that this can be somewhat breaking because people may have set up alerting rules based on environment but I think this is a good change in general.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.12 KB (+0.07% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 62.52 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.76 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55.51 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped + minified) 20.5 KB (+0.08% 🔺)
@sentry/browser - Webpack (minified) 66.97 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped + minified) 20.52 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.12 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.09 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.33 KB (+0.08% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 42.87 KB (+0.03% 🔺)
@sentry/replay - Webpack (gzipped + minified) 36.93 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 60.49 KB (+0.04% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 54 KB (+0.02% 🔺)

@mydea
Copy link
Member Author

mydea commented Mar 3, 2023

We just have to be aware that this can be somewhat breaking because people may have set up alerting rules based on environment but I think this is a good change in general.

Yeah, I though the same, not 100% sure, I'd tend towards is fine because it def. seems more like a bug/unexpected behavior.

@mydea mydea merged commit 97c6851 into develop Mar 6, 2023
@mydea mydea deleted the fn/default-env branch March 6, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sessions sent without an environment when environment option is not set
3 participants