fix(profiling): Guard from throwing if profiler constructor throws #7328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/profiling/feature-check-wrap
branch
from
f902c1d
to
4d4b39c
Compare
lforst
changed the title
lforst
approved these changes
Mar 3, 2023
|
|
||
| it('does not throw if Profiler is not available', () => { | ||
| // @ts-ignore force api to be undefined | ||
| global.window.Profiler = undefined; |
There was a problem hiding this comment.
Do we need to reset this like we do with document, window and location?
There was a problem hiding this comment.
@lforst I think this is already done in beforeEach where we override the global.window object with the new one from the fresh jsdom instance
There was a problem hiding this comment.
Ah right. Didn't see that Profiler was on the window object. Sorry about that!
There was a problem hiding this comment.
All good :D always better to ask then to miss it :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If document-policy header is not set, the profiling API is still present but attempting to initialize the profiler will throw.
This PR guards from that by adding a try/catch block around the profiler constructor.