Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Use namespace import for react router v6 #7330

Merged
merged 1 commit into from Mar 6, 2023

Conversation

OliverJAsh
Copy link
Contributor

This is needed for the import to work in a TypeScript project that does not have allowSyntheticDefaultImports enabled.


Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

This is needed for the import to work in a TypeScript project that does not have `allowSyntheticDefaultImports` enabled.
@OliverJAsh OliverJAsh marked this pull request as ready for review March 3, 2023 15:36
@AbhiPrasad AbhiPrasad changed the title Use namespace import for React fix(react): Use namespace import for React Mar 6, 2023
@AbhiPrasad AbhiPrasad changed the title fix(react): Use namespace import for React fix(react): Use namespace import for react router v6 Mar 6, 2023
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @OliverJAsh!

@AbhiPrasad AbhiPrasad merged commit 0e63e3a into getsentry:develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants