feat(core): Ensure originalException has type unknown
#7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be typed as `Error | string | null` which is not correct, as technically _anything_ can be thrown. To reflect this existing reality, we have to broaden this type. Note that this _could_ lead to problems for users that currently depend on this type, but any potential issues arising because of this would actually be valid problems that should actually be fixed in the user code (e.g. relying on `error.message` to be present, for example).
mydea
changed the title
originalException has type unknownoriginalException has type unknown
mydea
changed the title
originalException has type unknownoriginalException has type unknown
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 7, 2023
masonmcelvain
added a commit
to iFixit/react-commerce
that referenced
this pull request
Mar 10, 2023
Checks that the original exception is an `Error` before trying to access it's `message` property. In getsentry/sentry-javascript#7361 the type of `originalException` changed to unknown, because in reality anything can be thrown in JS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be typed as
Error | string | nullwhich is not correct, as technically anything can be thrown. To reflect this existing reality, we have to broaden this type. Note that this could lead to problems for users that currently depend on this type, but any potential issues arising because of this would actually be valid problems that should actually be fixed in the user code (e.g. relying onerror.messageto be present, for example).This also allows us to update some other types from
anytounknown, which is IMHO more correct as we really just pass this through, whatever it is.Closes #7344