fix: Make redux integration be configurable via normalizeDepth
#7379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Mar 8, 2023
size-limit report 📦
|
mydea
reviewed
Mar 8, 2023
packages/utils/src/normalize.ts
Outdated
| // have already been normalized. | ||
| let overriddenDepth = depth; | ||
|
|
||
| if ((value as ObjOrArray<unknown>)['__sentry_override_normalization_depth__']) { |
There was a problem hiding this comment.
l: Maybe if typeof value['...'] === 'number'? Then we can remove the type cast below (I think?) and at least avoid this being incorrect. maybe overkill, though...
There was a problem hiding this comment.
sadly doesn't work because of the other type cast :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #7376
Makes the
normalizefunction overridable via a non-enumerable property on the normalization target.