-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript error in @sentry/types introduced in 7.42.0 #7422
Comments
#7382 is the PR that introduced this bug, specifically the following line:
|
Hello @HofmannZ , thank you for the report, this def. seems like something we should fix.
I suspect this has to do with how the code/types are tree shaken. (To be clear if that is the case we def. still need to fix this on our end, we'd just like to have a working reproduction so we can add a test to prevent future regressions like this) |
This reminds me of issue #5199. Again, the problem is that the DOM library is required. A possible fix/workaround is adding the library in tsconfig.json:
For pure backend/Node.js applications, however, this is not a clean way. We would like the dependency on DOM Types to be removed. |
Yes, to be clear we absolutely consider this a regression, you shouldn't need to adjust your tsconfig for this. We have an open PR and plan to ship a patch release as soon as possible! |
This should be fixed in 7.43.0 - thank you for reporting! |
Version |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using? If you use the CDN bundles, please specify the exact bundle (e.g.
bundle.tracing.min.js
) in your SDK setup.@sentry/node
SDK Version
7.42.0
Framework Version
No response
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce
@sentry/types
,@sentry/tracing
,@sentry/integrations
and@sentry/node
version7.41.0
.7.42.0
.Expected Result
It should build without errors.
Actual Result
Throws the following build error:
The text was updated successfully, but these errors were encountered: