Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sveltekit): Add performance monitoring for client load #7537

Merged
merged 6 commits into from Mar 22, 2023
Merged

feat(sveltekit): Add performance monitoring for client load #7537

merged 6 commits into from Mar 22, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 20, 2023 •
edited

ref #7526

@AbhiPrasad AbhiPrasad self-assigned this Mar 20, 2023
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 20, 2023
Closed
@Lms24 Lms24 mentioned this pull request Mar 21, 2023
Closed
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 21, 2023
Merged
@AbhiPrasad AbhiPrasad force-pushed the abhi-sveltekit-perf-monitor-load-client branch from 742e9a1 to 6e30ae3 Compare March 22, 2023 14:09
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.44 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 63.52 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.77 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.21 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.4 KB (0%)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.94 KB (0%)

@AbhiPrasad AbhiPrasad marked this pull request as ready for review March 22, 2023 14:43
@AbhiPrasad AbhiPrasad requested review from Lms24 and mydea March 22, 2023 14:43
Lms24
Lms24 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Let's get this in first and then figure out if/what we need to do with event.fetch to get trace propagation working.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 22, 2023 15:01
@AbhiPrasad AbhiPrasad force-pushed the abhi-sveltekit-perf-monitor-load-client branch from 7492f1b to e04378a Compare March 22, 2023 15:03
@AbhiPrasad AbhiPrasad merged commit 09ee30b into develop Mar 22, 2023
27 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-sveltekit-perf-monitor-load-client branch March 22, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @Lms24