Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Consider tracing error handler for process exit #7558

Merged
merged 6 commits into from Mar 22, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 21, 2023

We attempt to replicate node.js default behaviour of exiting when no error listeners are attached while ignoring Sentry's own listeners.

I noticed that the tracing error handler was not considered.

Magic strings don't feel the ideal way to do this but avoids adding exports to @sentry/core.

@timfish timfish marked this pull request as ready for review March 21, 2023 19:19
@timfish
Copy link
Collaborator Author

timfish commented Mar 21, 2023

Oops, a function name is readonly in strict mode...

@AbhiPrasad
Copy link
Member

Oops, a function name is readonly in strict mode

it's always the little things that get you 😭

@AbhiPrasad AbhiPrasad merged commit a73f58b into getsentry:develop Mar 22, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants