Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Capture replay mutation breadcrumbs & add experiment #7568

Merged
merged 5 commits into from Mar 24, 2023
Merged

feat(replay): Capture replay mutation breadcrumbs & add experiment #7568

merged 5 commits into from Mar 24, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 22, 2023 •
edited by billyvg

Adds _experiments.mutationLimit to experiment with this.
This will result in any mutations with more than the given amount of mutations will trigger a full snapshot instead of an incremental one with a lot of mutations.

Closes #7530
Closes #7529

@mydea mydea requested review from billyvg and Lms24 March 22, 2023 14:01
@mydea mydea self-assigned this Mar 22, 2023
mydea
mydea commented Mar 22, 2023
View reviewed changes
packages/replay/src/replay.ts Outdated Show resolved Hide resolved
billyvg
billyvg reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some small 🚲 🏠

packages/replay/src/replay.ts Outdated Show resolved Hide resolved
packages/replay/src/replay.ts Outdated Show resolved Hide resolved
packages/replay/src/replay.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.66 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.88 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.93 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.1 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.37 KB (+0.1% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.44 KB (+0.13% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.59 KB (+0.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.1 KB (+0.07% 🔺)

@mydea
Copy link
Member Author

mydea commented Mar 22, 2023

I addressed the PR feedback @billyvg !

billyvg
billyvg approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@mydea mydea force-pushed the fn/mutation-size branch 4 times, most recently from 878f9a8 to c542a36 Compare March 24, 2023 09:24
@mydea mydea merged commit a2103f3 into develop Mar 24, 2023
49 checks passed
@mydea mydea deleted the fn/mutation-size branch March 24, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@mydea mydea

Labels
Package: replay
Projects
None yet
Milestone
No milestone
3 participants
@mydea @billyvg @Lms24