Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replay): Add replay_id to transaction DSC #7571

Merged
merged 6 commits into from Mar 23, 2023
Merged

feat(replay): Add replay_id to transaction DSC #7571

merged 6 commits into from Mar 23, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 22, 2023

This adds replay_id to the DSC of transactions.

Closes #7555
Supersedes #7493

@mydea mydea self-assigned this Mar 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified) 71.66 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.87 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.92 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.09 KB (+0.08% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.33 KB (+0.08% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.39 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.53 KB (+0.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.06 KB (+0.06% 🔺)

JoshFerge
JoshFerge approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

AbhiPrasad
AbhiPrasad approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good api

@mydea mydea merged commit 579d119 into develop Mar 23, 2023
53 checks passed
@mydea mydea deleted the fn/replay-dsc branch March 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshFerge JoshFerge JoshFerge approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@billyvg billyvg Awaiting requested review from billyvg

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@mydea mydea

Labels
Package: replay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sentry-replay_id to DSC
3 participants
@mydea @JoshFerge @AbhiPrasad