fix(otel): Make sure we use correct hub on finish #7577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
commented
Mar 22, 2023
| } | ||
| const scope = hub.getScope(); | ||
| if (!scope) { | ||
| __DEBUG_BUILD__ && logger.error('SentrySpanProcessor has triggered onStart before a scope has been setup.'); |
There was a problem hiding this comment.
We can remove all of this because a hub should always be defined (and scope is actually never used anywhere).
3 tasks
size-limit report 📦
|
mydea
reviewed
Mar 23, 2023
| @@ -162,6 +145,8 @@ export class SentrySpanProcessor implements OtelSpanProcessor { | |||
|
|
|||
| if (sentrySpan instanceof Transaction) { | |||
| updateTransactionWithOtelData(sentrySpan, otelSpan); | |||
| // @ts-ignore TODO: fix this | |||
Lms24
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7538
This one was tricky to debug...
On transactions we store the hub that called
hub.startTransaction(). This was because we have the assumption that the hub that callsstartTransactionwill be the one that finishes it.In OpenTelemetry world this isn't the case, since our hub cloning (via domains) does not map exactly to otel context forking (via async hooks). This means async hooks might fork first, leading to the incorrect hub being used on transaction finish.
I do not want to remove the setting hub in transaction constructor, since that is needed for browser world, but to make due temporarily I added a method to override what hub is on the transaction.
The span processor then sets a new hub on finish.