Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Auto discovery only returns integrations where dependency loads #7603

Merged
merged 3 commits into from Mar 24, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 23, 2023

The current auto discovery returns all integrations and they only become disables when setupOnce is called.

This means all the integrations are retained by the client and listed in sent envelopes.

This PR:

  • Adds LazyLoadedIntegration which adds a loadDependency method that allows us to preemptively load the dependency and check whether we should return the integration
  • Modifies the auto discovered integrations to implement LazyLoadedIntegration

@timfish timfish marked this pull request as ready for review March 24, 2023 11:02
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 24, 2023 12:02
@AbhiPrasad AbhiPrasad merged commit e1af1e6 into getsentry:develop Mar 24, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants