feat(replay): Add responseStatus, decodedBodySize to perf entries
#7613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few more properties to `resource` performance entries (e.g. script, img, etc). * Adds `responseStatus` which is new in Chrome 109 for status code * Adds `decodedBodySize` so that we can tell user if their resource was compressed or not.
size-limit report 📦
|
mydea
reviewed
Mar 27, 2023
| responseStatus?: number; | ||
| }; | ||
|
|
||
| export type PaintData = undefined; |
There was a problem hiding this comment.
this seems a bit weird? Should this be undefined?
There was a problem hiding this comment.
Yeah it is a bit weird but we don't attach data for paint, so those breadcrumbs will not have a data attribute at all
mydea
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few more properties to
resourceperformance entries (e.g. script, img, etc).responseStatuswhich is new in Chrome 109 for status codedecodedBodySizeso that we can tell user if their resource was compressed or not.