Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Remove abs_path from stack trace (reverting #7167) #7623

Merged
merged 1 commit into from Mar 27, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 27, 2023

In #7167 we added abs_path to the stack frames inside error events. We thought we needed this to make the new debug ID source map resolving process more resilient against people using the RewritieFrames integration.

Unfortunately, this change rendered the usage of RewriteFrames completely useless in most cases because Symbolicator only looks at abs_path and not filename, and up until now, everything only worked because abs_path got backfilled by filename in Relay if it was not defined.

This PR reverts the change in #7167 and falls back to using filename for the debug ID process. This means that RewriteFrames has the possibility to screw up that system but that should be fine since 1) people who have a RewriteFrames likely already have working source maps in place 2) we can tell people to not use RewriteFrames in combination with the debug ID process.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.56 KB (-0.06% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.19 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.12 KB (-0.07% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped + minified) 21.58 KB (-0.06% 🔽)
@sentry/browser - Webpack (minified) 71.65 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.6 KB (-0.06% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.94 KB (-0.11% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.92 KB (-0.05% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.09 KB (-0.06% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.37 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.44 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.58 KB (-0.03% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.09 KB (-0.03% 🔽)

@lforst lforst merged commit 0fab403 into develop Mar 27, 2023
52 checks passed
@lforst lforst deleted the lforst-remove-abs-path-again branch March 27, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants