fix(core): Remove abs_path
from stack trace (reverting #7167)
#7623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7167 we added
abs_path
to the stack frames inside error events. We thought we needed this to make the new debug ID source map resolving process more resilient against people using theRewritieFrames
integration.Unfortunately, this change rendered the usage of
RewriteFrames
completely useless in most cases because Symbolicator only looks atabs_path
and notfilename
, and up until now, everything only worked becauseabs_path
got backfilled byfilename
in Relay if it was not defined.This PR reverts the change in #7167 and falls back to using
filename
for the debug ID process. This means thatRewriteFrames
has the possibility to screw up that system but that should be fine since 1) people who have aRewriteFrames
likely already have working source maps in place 2) we can tell people to not useRewriteFrames
in combination with the debug ID process.