Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Ensure pageload transaction starts at timeOrigin #7632

Merged
merged 2 commits into from Mar 28, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 28, 2023

This adjusts the pageload transaction to ensure its start is always the timeOrigin.
This should help with e.g. lazy loading sentry, where we still want this to be accurate.

@mydea mydea self-assigned this Mar 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.61 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.39 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.16 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.62 KB (0%)
@sentry/browser - Webpack (minified) 72.03 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.64 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.99 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.15 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.35 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.47 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.54 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.13 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.22 KB (0%)

@mydea mydea force-pushed the fn/delayed-loading-timing branch from 678dd8e to b2867b4 Compare March 28, 2023 12:52
@mydea mydea merged commit 849297a into develop Mar 28, 2023
43 checks passed
@mydea mydea deleted the fn/delayed-loading-timing branch March 28, 2023 14:26
@langovoi
Copy link

langovoi commented Apr 14, 2023

@mydea I think this PR broke some of custom metrics in our project.

We use span.endTimestamp - transaction.startTimestamp to make some custom metrics. After upgrade to 7.46.0 we faced with negative values because span.endTimestamp is milliseconds, but transaction.startTimestamp became microseconds.

Is it expected behavior?

@mydea
Copy link
Member Author

mydea commented Apr 17, 2023

Ugh, sorry about that! I will open a PR to fix this!

@mydea
Copy link
Member Author

mydea commented Apr 20, 2023

Hi @langovoi ,

we've just released 7.49.0 which should fix this issue! sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants