Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Add loading component type to server component wrapping #7639

Merged
merged 1 commit into from Mar 29, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Mar 29, 2023

Ref #6726

We missed the loading.tsx component in the server component wrapping logic.

@lforst lforst requested review from mydea and Lms24 March 29, 2023 10:01
@lforst lforst self-assigned this Mar 29, 2023
@lforst lforst changed the title fix(nextjs): Add missing component type to server component wrapping fix(nextjs): Add loading component type to server component wrapping Mar 29, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.62 KB (+0.07% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.4 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.16 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 56.78 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.53 KB (-0.39% 🔽)
@sentry/browser - Webpack (minified) 72 KB (-0.04% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.55 KB (-0.39% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.98 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.16 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.36 KB (+0.06% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.74 KB (+0.62% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.86 KB (+0.83% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 63.41 KB (+0.46% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.49 KB (+0.5% 🔺)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anyway we can ensure that we are keeping track of new component types as they come out?

@lforst lforst merged commit e7a0b1c into develop Mar 29, 2023
30 of 31 checks passed
@lforst lforst deleted the lforst-add-missing-component-type branch March 29, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants