feat(sveltekit): Add Undici integration by default #7650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Mar 29, 2023
| initNodeSdk(options); | ||
|
|
||
| configureScope(scope => { | ||
| scope.setTag('runtime', 'node'); | ||
| }); | ||
| } | ||
|
|
||
| function addServerIntegrations(options: NodeOptions): void { |
There was a problem hiding this comment.
m: before adding this integration, don't we need to check for hasTracingEnabled?
At least that's how we do it on the client-side
There was a problem hiding this comment.
We don't need to worry about bundle size + the integration should gracefully handle when tracing is not enabled, so I think the answer is no.
We have this logic in next.js because the http integration by default sets tracing to be false - you have to opt-in to it (which is what the nextjs SDK adds for you).
Lms24
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7624
Depends on #7646