Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sveltekit): Don't capture thrown Redirects as exceptions #7731

Merged
merged 2 commits into from Apr 4, 2023
Merged

fix(sveltekit): Don't capture thrown Redirects as exceptions #7731

merged 2 commits into from Apr 4, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 4, 2023

As outlined in the SvelteKit docs, users can throw redirect(300, 'route/to/redirect') in load functions. We don't want to capture these as errors and send them to Sentry.

closes #7719

@Lms24 Lms24 requested a review from AbhiPrasad April 4, 2023 13:54
@Lms24 Lms24 merged commit 52b764e into develop Apr 4, 2023
29 checks passed
@Lms24 Lms24 deleted the lms/sveltekit-fix-redirects branch April 4, 2023 15:18
This was referenced May 25, 2023
Closed
Merged
Lms24 added a commit that referenced this pull request May 25, 2023
@Lms24
fix(sveltekit): Avoid capturing redirects and 4xx Http errors in requ…
41fef4b 
…est Handlers (#8215)

Stop sending thrown redirects and 4xx Http errors to
Sentry. This change is identical to #7731 which introduced these filters
to `load` functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SvelteKit redirects thrown in instrumented load functions should not trigger captureException
2 participants
@Lms24 @AbhiPrasad