fix(angular): Only open report dialog if error was sent #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can open a PR to do this in React as well. |
Lms24
requested review from
a team,
mydea and
AbhiPrasad
and removed request for
a team
Lms24
commented
Apr 5, 2023
| @@ -57,7 +57,7 @@ | |||
| "lint": "run-s lint:prettier lint:eslint", | |||
| "lint:eslint": "eslint . --format stylish", | |||
| "lint:prettier": "prettier --check \"{src,test,scripts}/**/**.ts\"", | |||
| "yalc:publish": "ts-node ../../scripts/prepack.ts && yalc publish build --push" | |||
| "yalc:publish": "yalc publish build --push" | |||
There was a problem hiding this comment.
Just noticed while testing with yalc that we don't need to call the prepack script here
AbhiPrasad
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #7732, the report dialog in the Angular SDK opens even if an event was dropped before it's sent.
This PR leverages lifecycle hooks (
afterSendEvent) to open the dialog if they're available. It keeps the current behaviour as a fallback if hooks are not available. Also adjusted tests for the change.Tested locally with my Angular test apps and this I can no longer reproduce the bug in #7732
We should do the same change in the react SDK
closes #7732