Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky CI]: Remix Node 16 Firefox meta tag test #8398

Closed
AbhiPrasad opened this issue Jun 23, 2023 · 2 comments · Fixed by #8506
Closed

[Flaky CI]: Remix Node 16 Firefox meta tag test #8398

AbhiPrasad opened this issue Jun 23, 2023 · 2 comments · Fixed by #8506

Comments

@AbhiPrasad
Copy link
Member

Flakiness Type

Timeout

Name of Job

Remix (Node 16) Tests

Name of Test

test/integration/test/client/meta-tags.test.ts

Link to Test Run

https://github.com/getsentry/sentry-javascript/actions/runs/5357099828/jobs/9717692588

Details

1) [firefox] › test/integration/test/client/meta-tags.test.ts:33:5 › should send transactions with corresponding `sentry-trace` and `baggage` inside root page 

    Test timeout of 30000ms exceeded.

    page.goto: Navigation failed because page was closed!
    =========================== logs ===========================
    navigating to "http://localhost:3000/", waiting until "load"
    ============================================================

       at ../browser-integration-tests/utils/helpers.ts:219

      217 |
      218 |   if (options?.url) {
    > 219 |     await page.goto(options.url);
          |                ^
      220 |   }
      221 |
      222 |   return requests;

        at getMultipleRequests (/home/runner/work/sentry-javascript/sentry-javascript/packages/browser-integration-tests/utils/helpers.ts:219:16)
        at getMultipleSentryEnvelopeRequests (/home/runner/work/sentry-javascript/sentry-javascript/packages/browser-integration-tests/utils/helpers.ts:238:10)
        at getFirstSentryEnvelopeRequest (/home/runner/work/sentry-javascript/sentry-javascript/packages/browser-integration-tests/utils/helpers.ts:254:17)
        at /home/runner/work/sentry-javascript/sentry-javascript/packages/remix/test/integration/test/client/meta-tags.test.ts:34:55

    Pending operations:
      - page.goto at ../browser-integration-tests/utils/helpers.ts:219:16



  1 failed
@onurtemizkan
Copy link
Collaborator

It also happens in other tests running on Node 16 and Firefox:
https://github.com/getsentry/sentry-javascript/actions/runs/5463217111/jobs/9943841194

Might be this issue microsoft/playwright#12182

@AbhiPrasad
Copy link
Member Author

for now let's just disable the firefox tests - if they're flaky they are low value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants