Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Use latest || * instead of * as version #8585

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 19, 2023

Due to the way pnpm handles versions, the version * we use in E2E tests is actually incorrect, because it installs the lowest version it can find, e.g. 0.1.0. This is usually not a problem as when we use verdaccio, there is only a single version in the repository. however, when running things locally/debugging stuff, and you run pnpm install without verdaccio, stuff fails. This updates the versions used in E2E tests to latest || *, which results in a correct resolution.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mydea mydea merged commit 67c3b6a into develop Jul 21, 2023
32 checks passed
@mydea mydea deleted the fn/e2e-versions branch July 21, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants