meta: Update CHANGELOG for 7.60.1 #8650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
Instead of looking up folders in `package`, fetch the packages from the root package.json. This way, if you e.g. have empty folders or similar in your `package/` dir, it will not fail. I notice this sometimes when working with new packages or similar, and switching branches, you may have leftover empty directories in `packages/`, which leads to integration tests failing unless you make sure to delete the directories.
Made updates about test server termination. Integrated [`http-terminator`](https://www.npmjs.com/package/http-terminator) as closing all sockets / cancelling pending requests and such produced plenty of maintenance code. Also, found out that [`portfinder`](https://www.npmjs.com/package/portfinder) does not work well in Node 20, and causes flakiness. Removed it from Remix and NextJS tests, as it can be replaced with `app.listen(0, ...)`.
As a possible fix for #8589, this sets up our integration tests to only run tests in firefox when the test contains `@firefox`. This way, we manually tag tests we want to run in firefox, as the tests are quite often flaky. We may think about reverting this once microsoft/playwright#12182 is fixed.
We can try to parse the used package from the issue body and auto-add the corresponding label.
We've been using `context.initialTimestamp` to check for min/max session duration, but actually this is always updated when a tab is refreshed, for example. Instead, we now use `session.started`, which should also always be updated for a buffer session. --------- Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Oops, apparently keys are regexes, so need to escape them I think: https://github.com/getsentry/sentry-javascript/actions/runs/5655218559/job/15319870320 Let's see if that fixes it...
This refactors how we run E2E tests, to a more simple approach.
This adds a super basic remix test scenario that handles booting the server & closing it again properly, ensuring tests don't hang but verify that remix boots up as expected.
Turns out the action trims whitespace, which leads to this failing. Damn - but it should work with `.` inside as well. A bit hacky, but well...
This updates the size limit config a bit, to be a bit more structured.
Apparently click+shift also opens a link in a new tab (and focuses the tab immediately), so we also need to ignore such clicks for slow click detection. Closes getsentry/team-replay#128
AbhiPrasad
approved these changes
Jul 26, 2023
mydea
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few important fixes, let's get them out.