Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): Trim idle transaction spans if they exceed final timeout #8653

Merged
merged 5 commits into from
Jul 27, 2023
Merged

fix(tracing): Trim idle transaction spans if they exceed final timeout #8653

merged 5 commits into from
Jul 27, 2023

Conversation

AbhiPrasad
Copy link
Member

Supercedes #8505

resolves #8504

If an idle transaction's duration is longer than final timeout + idle timeout, opt to not capture and send it to Sentry.

@AbhiPrasad AbhiPrasad requested review from krystofwoldrich, a team, mydea and Lms24 and removed request for a team July 26, 2023 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.07 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.4 KB (+0.16% 🔺)
@sentry/browser - Webpack (gzipped) 21.95 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.79 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.28 KB (+0.12% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.33 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.89 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.99 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 60.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.41 KB (+0.12% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.14 KB (0%)
@sentry/react - Webpack (gzipped) 21.96 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.91 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.89 KB (+0.11% 🔺)

@krystofwoldrich
Copy link
Member

Dropping the span that goes over the final timeout sounds like a good quick solution. 👍

krystofwoldrich
krystofwoldrich approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚀

I think maybe we should fo a small troubleshooting docs update for people running into the long Tx.

@AbhiPrasad
Copy link
Member Author

I think maybe we should fo a small troubleshooting docs update for people running into the long Tx.

Good idea, let me put in my todo!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) July 27, 2023 15:41
@AbhiPrasad AbhiPrasad merged commit aff5677 into develop Jul 27, 2023
78 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-idle-transaction-trim branch July 27, 2023 15:59
@krystofwoldrich krystofwoldrich mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IdleTransaction duration should not exceed final timeout
3 participants
@AbhiPrasad @krystofwoldrich @Lms24