-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): Add setName
method on spans
#8725
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
/** | ||
* @inheritDoc | ||
*/ | ||
public setName(name: string): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No action required: Should we think about adding span name source
field? I was just thinking that in a world of #onlyspans we probably still need a way to annotate the name source, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now the answer is no - but we'll come back to this.
0624c20
to
0ac3d31
Compare
ref #8724
In preparation for adding the new span creation methods,
startSpan
andstartActiveSpan
, this PR addsname
tospanContext
. Over time we are going to be moving away fromspan.description
, and this is the first step to get there.For now,
name
is just an alias forspan.description
, and is only added so that users can dorelatively easily.
Next steps is to add the span creators!