-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: Update CHANGELOG for 7.61.1 #8726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
…8684) Just clarify the readme about what is/not supported for node-experimental.
…an error (#8671) This PR adds support for capturing an exception for the any error in a console method call (only the first error instance), not just if the first argument is an error. This is a problem for us because timestamps are always the first argument in console calls and we often add a context message before the error.
Adds additional tests for `aria-label`. Will be needed for rrweb2 upgrade
We limit to max. 100 IDs being captured per replay, and ensure we do not capture stuff when replay has been disabled in the meanwhile.
To ensure we wait for the correct check to pass before continuing with publishing.
This updates the way we auto-lookup integrations. Due to how OTEL instrumentation works, we actually do not need any dynamic require. Otel instrumentation will generally always work, it only actually instruments when something is required/imported. So all integration _will_ be added, they will simply do nothing if the package is not used. This also updates the readme to clarify this & restrictions.
…#8687) In slack we reported a bug where there seemed to be the wrong parent span id attached to outgoing `sentry-trace` headers. This ends up being because the `addTracingHeadersToFetchRequest` attempts to use the transaction instead of the active request span to generate the outgoing `sentry-trace` header. This fixes that by adding the span to the `addTracingHeadersToFetchRequest` method.
One of a few steps to try to fix canary tests...
As well as fixes the ordering of operations and removes some redundant code. The stack should be trimmed _after_ filtering. Fixes #8396
* Re-add support for `-t` arg to filter for specific tests * Re-add support for `--watch` flag * Reduce logging for test suites where all tests were skipped. * Add `yargs` to parse arguments (and provide help)
…es` integration (#8715) Before applying ContextLines, we should check that the integration is registered on the current hub
Modified one template to use the async function instead, as adding an additional variant to an already bloated integration test runner felt meh. Note that type from #7444 is incorrect. It should be: ```js const nextConfig = async () => { /** @type {import('next').NextConfig} */ return {}; } ``` and not: ```js /** @type {import('next').NextConfig} */ const nextConfig = async () => { return {}; } ``` Note #2: async function handling works for `next >= 12.1` only: https://nextjs.org/docs/app/api-reference/next-config-js/pageExtensions Verified the behavior locally using provided sample config from the original issue. Fixes #7444
…ineno is out of bounds (#8722)
This streamlines & improves logging for replay status, adding more logs for certain things to be better able to see what's going on, and adapting the `traceInternals` setting to result in console breadcrumbs being added (which should show up both in replay and for e.g. sentry errors etc). While at it I also fixed some `any` eslint warnings in replay. ref: #8400
We haven't been persisting the `shouldRefresh` property of the session. This combined with the fact that we do not update the `sampled` field on the session to `session` when an error occurs, but keep it at `buffer`, means that if a user reloads the page or the session is otherwise re-fetched from sessionStorage, if previously an error occurs, we'll keep buffering forever again (like for a "fresh" buffer session), and if an error happens we convert it again to a `session` session, but since the session ID was never updated this will be "added" to the previous session instead. I made a reproduction test that failed before and works after this fix. Fixes #8400
This does two things: 1. Ensure we switch the `recordingMode` only once, to avoid running this process twice if e.g. multiple errors happen 2. Do not update `session.started` property when switching buffer->session. We just keep started at whatever was the first event sent. --------- Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
This fix ensures that if we try to flush a replay that is too short, we will debounce flush it again after the min. duration is reached.
Lms24
requested review from
a team,
kamilogorek,
ale-cota and
lforst
and removed request for
a team
August 3, 2023 08:50
lforst
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the one
feat
in there isn't user facing, I think it's ok to keep this as a patch.