-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: Update CHANGELOG for version 7.62.0 #8754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
To actually align with the monorepo rules. We were actually not applying the general eslint rules for the ember package, leading to a bunch of more ambiguous typing. Also tests were all in JS, not TS, I streamlined this as well.
…JS stack frames (#8699) Adds a "best-effort" `ContextLines` integration as an optional integration for the browser SDKs to pick up source code of and around stack frames pointing to code that's directly embedded in the current page's html. See PR and linked issue about limitations.
This delays adding the internal replay logging breadcrumbs to the next tick, to avoid race conditions on initial logs where replay may not be initialized yet. With this, you should get proper log breadcrumbs in a replay for itself.
Not sure if this has an impact, but it makes sense to cancel debounce anyhow in the case where we are too long/short. When we are too short, we schedule a new flush anyhow.
This _shouldn't_ happen, but it makes sense to guard so we only clear the event buffer cache on checkouts when in `buffer` mode. I guess the behavior of rrweb is not 100% defined in that it _cannot_ generate a new checkout in non-buffer mode 🤔 better safe than sorry.
…heckout (#8748) We keep track of the eventBuffer contains a checkout, and if not, log a warning when trying to flush the initial segment. If this turns out to be happening, we may think about aborting flushing or similar in this case. But for now, we can gather data.
The Electron SDK uses `basename` to get the file name without path but this returned the full path on Windows. This PR adds Windows support to the regex and adds some tests.
… and other required jobs (#8751) Adjust our final "Required Tests Passed" CI job to not only depend on required _test_ jobs but on _all_ required jobs. Specifically, this adds * Lint * Circular deps check * Most importantly: Upload Artifacts With this change, we can configure craft's status provider to specifically wait for this job which should fix the artifacts download timeout (getsentry/craft#482). It's worth noting that this PR will only fix this timeout in our repo and in a way we're adjusting to the status provider check. However, given that we're apparently the only repo where this happens, it's probably justified and it makes things more explicit.
Lms24
requested review from
a team,
kamilogorek,
lforst and
mydea
and removed request for
a team
August 8, 2023 14:07
Lms24
force-pushed
the
prepare-release/7.62.0
branch
from
August 8, 2023 14:07
039a4b9
to
6f4ce44
Compare
AbhiPrasad
reviewed
Aug 8, 2023
Lms24
force-pushed
the
prepare-release/7.62.0
branch
from
August 8, 2023 14:19
606f0a1
to
cf0c04c
Compare
mydea
reviewed
Aug 8, 2023
Lms24
force-pushed
the
prepare-release/7.62.0
branch
from
August 8, 2023 14:30
623849f
to
9070e3e
Compare
mydea
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
alltheref
PRs mentioned are somewhat user-facing, hence I left them in but we can ofc remove them if anyone has opinions on that