Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Defer tracing decision to downstream SDKs when using SDK without performance #8839

Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Aug 18, 2023

Currently, since the introduction of "Tracing without Performance", we always set a negative sampling decision on the tracing context when there is not an active transaction. This could get problematic because we might overrule the sampling decisions for all downstream SDKs when there are no active transactions and when we're the head-SDK.

Per spec, it is allowed to leave away the sampling decision in the sentry-trace header. The use-case for this is to defer the sampling decision, which is exactly what we want to do.

@lforst lforst requested a review from AbhiPrasad August 18, 2023 10:10
@lforst lforst changed the title fix: Defer tracing decision for tracing context without performance fix: Defer tracing decision for tracing context when using SDK without performance Aug 18, 2023
@lforst lforst changed the title fix: Defer tracing decision for tracing context when using SDK without performance fix: Defer tracing decision to downstream SDKs when using SDK without performance Aug 18, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.18 KB (+0.44% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.16 KB (+0.16% 🔺)
@sentry/browser - Webpack (gzipped) 21.84 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.72 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.17 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.18 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.93 KB (+0.4% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.75 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.85 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.04 KB (+0.07% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.2 KB (+15.6% 🔺)
@sentry/react - Webpack (gzipped) 21.87 KB (+0.15% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.02 KB (+0.4% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.69 KB (+0.17% 🔺)

@lforst lforst requested a review from cleptric August 28, 2023 07:38
@lforst lforst merged commit 7ed50ed into develop Aug 28, 2023
78 checks passed
@lforst lforst deleted the lforst-defer-sampling-decision-when-tracing-without-performance branch August 28, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants