New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Always use event message and exception values for ignoreErrors
#8986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, lgtm
logger.error(`Could not extract message for event ${getEventDescription(event)}`); | ||
} | ||
|
||
console.log(possibleMessages); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 💀
size-limit report 📦
|
Previously when event had a
message
, the SDK didn't look into the exception value to filter forignoreErrors
.This PR changes the behaviour so that
event.message
andexception.value
+exception.
are always both considered for filtering.Ref: #2520