Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint): Enforce that ts-expect-error is used #8987

Merged
merged 2 commits into from Sep 11, 2023

Conversation

AbhiPrasad
Copy link
Member

Based on work in #8974

Enforce that @ts-expect-error is used instead of @ts-ignore. This is done by updating the typescript-eslint/ban-ts-comment rule.

https://typescript-eslint.io/rules/ban-ts-comment/

@AbhiPrasad AbhiPrasad requested review from a team, mydea and ale-cota and removed request for a team September 8, 2023 14:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.38 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.29 KB (+0.06% 🔺)
@sentry/browser - Webpack (gzipped) 21.89 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.08 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.4 KB (-0.07% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.47 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.54 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.82 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 60.67 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.28 KB (-0.05% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.4 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 21.92 KB (+0.07% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.27 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 50.85 KB (+0.04% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) September 8, 2023 14:47
@AbhiPrasad AbhiPrasad merged commit d3c3462 into develop Sep 11, 2023
78 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-enforce-ts-expect-error branch September 11, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants