fix(node-experimental): Ignore outgoing Sentry requests #8994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Sep 11, 2023
lforst
reviewed
Sep 11, 2023
| /** | ||
| * Checks whether given host points to Sentry server | ||
| */ | ||
| function isSentryHost(host: string | undefined): boolean { |
There was a problem hiding this comment.
we already have something like this in a few places. Maybe we can extract into a function.
There was a problem hiding this comment.
good point, will move it as a util to @sentry/core (can't be in utils as it needs access to getCurrentHub()!)
size-limit report 📦
|
|
Added an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do filter these out in the span processor, but we can avoid all this work by not even generating OTEL spans at all for outgoing Sentry requests.