Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): upgrade cookie to ^0.5.0 #9013

Merged
merged 1 commit into from Sep 14, 2023

Conversation

Dima-Dim
Copy link
Contributor

The current version of cookies includes several performance improvements.
https://github.com/jshttp/cookie/releases
And in general, I would like to bring the dependencies to the current versions in order to reduce duplication of the same dependencies, but with different versions.

Before:

├─┬ @sentry-internal/node-integration-tests@7.68.0 -> ./packages/node-integration-tests
│ └─┬ express@4.18.2
│   └── cookie@0.5.0
├─┬ @sentry/browser@7.68.0 -> ./packages/browser
│ └─┬ karma@6.3.16 invalid: "1 || 2 || 3 || 4" from node_modules/karma-typescript
│   └─┬ socket.io@4.5.3
│     └─┬ engine.io@6.2.0
│       └── cookie@0.4.2 deduped
├─┬ @sentry/node@7.68.0 -> ./packages/node
│ └── cookie@0.4.2
├─┬ @sentry/remix@7.68.0 -> ./packages/remix
│ └─┬ @remix-run/node@1.5.1
│   └─┬ @remix-run/server-runtime@1.5.1
│     └── cookie@0.4.2 deduped
└─┬ @sentry/sveltekit@7.68.0 -> ./packages/sveltekit
  └─┬ @sveltejs/kit@1.15.2
    └── cookie@0.5.0

After:

├─┬ @sentry-internal/node-integration-tests@7.68.0 -> ./packages/node-integration-tests
│ └─┬ express@4.18.2
│   └── cookie@0.5.0 deduped
├─┬ @sentry/browser@7.68.0 -> ./packages/browser
│ └─┬ karma@6.3.16 invalid: "1 || 2 || 3 || 4" from node_modules/karma-typescript
│   └─┬ socket.io@4.5.3
│     └─┬ engine.io@6.2.0
│       └── cookie@0.4.2
├─┬ @sentry/node@7.68.0 -> ./packages/node
│ └── cookie@0.5.0
├─┬ @sentry/remix@7.68.0 -> ./packages/remix
│ └─┬ @remix-run/node@1.5.1
│   └─┬ @remix-run/server-runtime@1.5.1
│     └── cookie@0.4.2
└─┬ @sentry/sveltekit@7.68.0 -> ./packages/sveltekit
  └─┬ @sveltejs/kit@1.15.2
    └── cookie@0.5.0 deduped

@AbhiPrasad
Copy link
Member

Can we rebuild the lockfile?

@Dima-Dim
Copy link
Contributor Author

Can we rebuild the lockfile?

It seems that in doses not change at all, because the project already has the use of cookie@0.5.0 and there still cookie@0.4.2 from other dependencies.

@AbhiPrasad AbhiPrasad changed the title chore: upgrade cookie to ^0.5.0 chore(node): upgrade cookie to ^0.5.0 Sep 13, 2023
@Dima-Dim
Copy link
Contributor Author

But I realized that I also need to update the version of the @types/cookie. And this changes the lock file.

@Lms24 Lms24 merged commit a65c7ef into getsentry:develop Sep 14, 2023
68 checks passed
billyvg pushed a commit that referenced this pull request Sep 15, 2023
The current version of cookies includes several performance
improvements: https://github.com/jshttp/cookie/releases
@AbhiPrasad
Copy link
Member

Released with https://github.com/getsentry/sentry-javascript/releases/tag/7.70.0 of the Node SDK. Thanks for contributing @Dima-Dim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants