Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Fix typo in Replay types #9028

Merged
merged 2 commits into from Sep 15, 2023
Merged

fix(replay): Fix typo in Replay types #9028

merged 2 commits into from Sep 15, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Sep 14, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.39 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.32 KB (0%)
@sentry/browser - Webpack (gzipped) 21.92 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.17 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.51 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.59 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.8 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.33 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.18 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.39 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.42 KB (0%)
@sentry/react - Webpack (gzipped) 21.95 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.28 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.89 KB (0%)

@billyvg billyvg marked this pull request as ready for review September 14, 2023 18:34
@billyvg billyvg requested a review from mydea September 14, 2023 18:34
@billyvg
Copy link
Member Author

billyvg commented Sep 14, 2023

Thanks @ryan953 for spotting this!

mydea
mydea approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn, search and replace 😬

@mydea mydea merged commit e24d7e0 into develop Sep 15, 2023
74 checks passed
@mydea mydea deleted the fix-replay-typo-in-iframe-type branch September 15, 2023 07:09
billyvg added a commit that referenced this pull request Sep 15, 2023
@billyvg
fix(replay): Fix typo in Replay types (#9028)
7283566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billyvg @mydea