fix(replay): Ensure replay events go through preprocessEvent hook
#9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Sep 15, 2023
size-limit report 📦
|
mydea
force-pushed
the
fn/ensure-replay-preprocessEvent
branch
from
b71fcb5
to
d9075a0
Compare
billyvg
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9022 for how this otherwise fails. Replay events also go through global event processors, so they should also go through this hook (replay events are not sent via the regular baseclient methods).
@JonasBa not sure if something like this also applies to profiles, but they should also go through this hook before
prepareEvent()is applied!