Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vercel-edge): add Vercel Edge Runtime package #9041

Merged
merged 5 commits into from Sep 19, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Sep 18, 2023

ref #8087

This PR adds a @sentry/vercel-edge SDK that can be used by our Next.js or Sveltekit SDKs for edge runtime support.

People can also use this standalone

There is a TODO to figure out how to test this with edge runtime environment, but I'll address this in a follow up PR.

@AbhiPrasad AbhiPrasad force-pushed the abhi-vercel-edge-config branch 2 times, most recently from 3a2032e to dafa758 Compare September 19, 2023 13:50
@AbhiPrasad AbhiPrasad self-assigned this Sep 19, 2023
@AbhiPrasad AbhiPrasad marked this pull request as ready for review September 19, 2023 14:24

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["node", "jest"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: is this the thing that's still left to figure out or can we use "@edge-runtime/types" instead of node here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this is part of the todo raised here

// TODO: Fix tests to work with the Edge environment
// testEnvironment: '@edge-runtime/jest-environment',

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Comment on lines +9 to +11
"engines": {
"node": ">=8"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Probably not too important but is this even relevant for edge?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wait I'm not, let's stick with making this the same as nextjs for now.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) September 19, 2023 16:04
@AbhiPrasad AbhiPrasad merged commit cd0bc3b into develop Sep 19, 2023
82 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-vercel-edge-config branch September 19, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants